On Tue, May 3, 2016 at 2:56 PM, Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx> wrote: > On Mon, May 2, 2016 at 10:59 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >> On Mon, May 2, 2016 at 11:31 PM, Zeeshan Ali (Khattak) >> <zeeshanak@xxxxxxxxx> wrote: >>> On Mon, May 2, 2016 at 7:52 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: >>>> On Mon, May 2, 2016 at 8:47 PM, Zeeshan Ali (Khattak) >>>> <zeeshanak@xxxxxxxxx> wrote: >>>>> Hi, >>>>> >>>>> I had forgotten that win8.1 also needs Boxes patch: >>>>> https://bugzilla.gnome.org/show_bug.cgi?id=765175 >>>>> >>>>> With the patch in that bug applied, win8.1 installer works. I think it >>>>> should be mentioned in the log on this patch. >>>> >>>> Hmm. I don't see a reason for mentioning here that the installation >>>> doesn't work properly due to a consumer's bug. >>> >>> Keeping in mind that Boxes is the reason we're working on this issue >>> and that other users (if any) of this functionality can easily have >>> the exact same issue, I think it's worth mentioning. >> >> Okay, I can add to the commit log: >> "In order to test this patch, you'll also need the following fix for >> gnome-boxes: >> https://bugzilla.gnome.org/show_bug.cgi?id=765175" >> >> Does it help? > > Well kinda. Firstly, the patch is not just needed for testing but for > scripts to actually work. 2ndly, it could be a bit more generic. > Something like "Windows >= 8.1 has stricter policy on hostname and > therefore apps might need to be patched for installer scripts to work: > https://bugzilla.gnome.org/show_bug.cgi?id=765175". I don't think it's only Windows >= 8.1. Doesn't make sense to be, to be honest. But I don't have time to start installing random versions of Windows just for testing it. The main thing is that 8.1 is the only version that has a dot on its name, which will cause the issue with Gnome Boxes, which does the replace of "." to "-". Do you want me to re-submit the whole series or just adding something similar to your suggestion is enough? > >>> >>>>> >>>>> On Mon, May 2, 2016 at 6:53 PM, Zeeshan Ali (Khattak) >>>>> <zeeshanak@xxxxxxxxx> wrote: >>>>>>> I haven't yet checked but issue might be addition of .cmd file since >>>>>>> afaik the spice-tools version we currently use at least, does not >>>>>>> install correctly on win8. >>>>>> >>>>>> I checked now and it's not likely to be the cmd file since I get the >>>>>> same error during post-installation even if cmd is not present and >>>>>> ran. >>>>>> >>>>>>> On Sun, May 1, 2016 at 10:57 PM, Fabiano Fidêncio <fidencio@xxxxxxxxxx> wrote: >>>>>>>> From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >>>>>>>> >>>>>>>> Now the unattended installation works properly, apart from the user >>>>>>>> avatar not being set for Windows 8 (or newer)[0]. >>>>>>>> >>>>>>>> [0]: https://bugzilla.redhat.com/show_bug.cgi?id=1328637 >>>>>>>> >>>>>>>> This reverts commit 49ae46cda4fbd2e95dc794cb64aec27117351c85. >>>>>>>> >>>>>>>> Signed-off-by: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> >>>>>>>> --- >>>>>>>> data/os/microsoft.com/win-8.1.xml.in | 11 +++++++++++ >>>>>>>> 1 file changed, 11 insertions(+) >>>>>>>> >>>>>>>> diff --git a/data/os/microsoft.com/win-8.1.xml.in b/data/os/microsoft.com/win-8.1.xml.in >>>>>>>> index a68c788..29b1fc6 100644 >>>>>>>> --- a/data/os/microsoft.com/win-8.1.xml.in >>>>>>>> +++ b/data/os/microsoft.com/win-8.1.xml.in >>>>>>>> @@ -136,5 +136,16 @@ >>>>>>>> <devices> >>>>>>>> <device id="http://pcisig.com/pci/8086/2668"/> <!-- ICH6 --> >>>>>>>> </devices> >>>>>>>> + >>>>>>>> + <!-- >>>>>>>> + User avatar not being set for Windows 8 (or newer). >>>>>>>> + For more details, please, see: >>>>>>>> + https://bugzilla.redhat.com/show_bug.cgi?id=1328637 >>>>>>>> + --> >>>>>>>> + <installer> >>>>>>>> + <script id='http://microsoft.com/windows/unattend/jeos'/> >>>>>>>> + <script id='http://microsoft.com/windows/unattend/desktop'/> >>>>>>>> + <script id='http://microsoft.com/windows/cmd/desktop'/> >>>>>>>> + </installer> >>>>>>>> </os> >>>>>>>> </libosinfo> >>>>>>>> -- >>>>>>>> 2.7.3 >>>>>>>> >>>>>>>> _______________________________________________ >>>>>>>> Libosinfo mailing list >>>>>>>> Libosinfo@xxxxxxxxxx >>>>>>>> https://www.redhat.com/mailman/listinfo/libosinfo >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Regards, >>>>>>> >>>>>>> Zeeshan Ali (Khattak) >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Regards, >>>>>> >>>>>> Zeeshan Ali (Khattak) >>>>> >>>>> >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> Zeeshan Ali (Khattak) >>>>> >>>>> _______________________________________________ >>>>> Libosinfo mailing list >>>>> Libosinfo@xxxxxxxxxx >>>>> https://www.redhat.com/mailman/listinfo/libosinfo >>>> >>>> >>>> >>>> -- >>>> Fabiano Fidêncio >>> >>> >>> >>> -- >>> Regards, >>> >>> Zeeshan Ali (Khattak) >> >> >> >> -- >> Fabiano Fidêncio > > > > -- > Regards, > > Zeeshan Ali (Khattak) _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo