On 25 March 2016 at 22:23, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: >> + <variant id="net-install"/> > > If you use variants, you need to define it first, for example fedora > has: > > <variant id="netinst"> > <_name>Fedora 21</_name> > </variant> I'll check that >> + <url>ftp://distrib-coffee.ipsl.jussieu.fr/pub/linux/Mageia/distrib/4/i586/install/images/boot.iso</url> > > Any reason this is not > https://www.mageia.org/en/downloads/get/?q=Mageia-5-Boot-i586-CD.iso ? > (I've changed this locally) No reason. Thx >> + <iso> >> + <volume-id>Mga Boot ISO</volume-id> >> + </iso> >> + <kernel>isolinux/i386/vmlinuz</kernel> >> + <initrd>isolinux/i386/all.rdz</initrd> >> + </media> >> + >> + <media arch="x86_64"> >> + <variant id="net-install"/> >> + <url>ftp://distrib-coffee.ipsl.jussieu.fr/pub/linux/Mageia/distrib/4/x86_64/install/images/boot.iso</url> >> + <iso> >> + <volume-id>Mageia 4 x86_64 Netinstall</volume-id> >> + </iso> >> + <kernel>isolinux/x86_64/vmlinuz</kernel> >> + <initrd>isolinux/x86_64/all.rdz</initrd> >> + </media> >> + >> + <media arch="i686"> >> + <url>https://www.mageia.org/en/downloads/get/?q=Mageia-4-i586-DVD.iso</url> > > Actually these links are not direct links to ISO images, but to a > webpage allowing to get the ISO image, I think the database usually > contains direct links to the ISO. I don't know if mageia provides such > link? (ie something similar to > http://download.fedoraproject.org/pub/fedora/linux/releases/21/Workstation/i386/iso/Fedora-Live-Workstation-i686-21-5.iso > which redirects to a mirror with the ISO if needed). I don't think there's such links. Note that: - the URL logic is the same for previous versions already in libosinfo - the download starts automatically after a couple seconds >> +<!-- >> + <url>http://www.mageia.org/fr/downloads/get/?q=Mageia-4-dual-CD.iso</url> >> +--> >> + <iso> >> + <volume-id>Mageia-4(-i586)?</volume-id> >> + </iso> >> + <kernel>isolinux/i386/vmlinuz</kernel> >> + <initrd>isolinux/i386/all.rdz</initrd> >> + </media> >> + <media arch="x86_64"> >> + <url>https://www.mageia.org/en/downloads/get/?q=Mageia-4-x86_64-DVD.iso</url> >> +<!-- >> + <url>http://www.mageia.org/fr/downloads/get/?q=Mageia-4-dual-CD.iso</url> >> +--> >> + <iso> >> + <volume-id>Mageia-4(-x86_64)?</volume-id> > > Both this regexp and the i586 one are going to match 'Mageia-4' > I understand you do that as the dual ISO is valid for both x86_64 and > i586, but this means the arch of matching 'Mageia-4' will be more or > less random. I'd make the i586 match stricter, and only let the x86_64 > regexp match the dual ISO. OK > I find it a bit odd to introduce the -unkown file, and then change it in > all the following patches. I've moved the introduction of the -unknown > file to the end of the series. Because I first registered the -unknown one b/c it's generic and that you then insisted I registered mga[45] too :-) Also this way, the next one who will update this (eg: adding mga6 in a couple monthes) will know what to update. _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
