On Fri, Nov 13, 2015 at 11:41 AM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > On Fri, Nov 13, 2015 at 11:39:49AM -0500, Zeeshan Ali (Khattak) wrote: >> On Fri, Nov 13, 2015 at 11:19 AM, Daniel P. Berrange >> <berrange@xxxxxxxxxx> wrote: >> > On Fri, Nov 13, 2015 at 11:16:15AM -0500, Zeeshan Ali (Khattak) wrote: >> >> For desktop profile. >> >> --- >> >> data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in >> >> index be7a965..24a4d6b 100644 >> >> --- a/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in >> >> +++ b/data/install-script/fedoraproject.org/fedora-kickstart-desktop.xml.in >> >> @@ -156,6 +156,9 @@ url --mirrorlist=https://mirrors.fedoraproject.org/metalink?repo=fedora-install- >> >> xorg-x11-drv-qxl >> >> spice-vdagent >> >> >> >> +# Also Qemu agent >> >> +qemu-guest-agent >> > >> > This surely needs to be made conditional based on some version >> > of Fedora, likewise for the other changes in this series, as the >> > one kicksart file is shared across many versions of the OS at >> > least some of which I expect pre-date qemu-guest-agent. >> >> It actually seems to predate Fedora itself. :) > > Unfortunately not - qemu-guest-agent is a sub-RPM of 'qemu' so > the changelog you're seeing is the changelog for qemu as a whole. > > I added it to Fedora in this dist-git commit > > commit f057293300c43e749ee543178ab95f0e285949cd > Author: Daniel P. Berrange <berrange@xxxxxxxxxx> > Date: Wed Oct 5 16:00:36 2011 +0100 > > Fix packaging of the QEMU guest agent Ah ok, so I'll modify this patch. As for others: * RHEL 6.* had this package and this is the first RHEL release for which we list installer scripts for, so no issue there AFAIK. * Debian seems to have added the package in debian squeeze (6) and desktop installer script is only listed from wheezy (7) and onwards, so no need for conditionals there either. -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
