On Wed, Apr 01, 2015 at 06:40:51PM +0100, Zeeshan Ali (Khattak) wrote: > On Wed, Apr 1, 2015 at 5:00 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > Hey, > > > > On Thu, Mar 26, 2015 at 02:39:31PM +0000, Zeeshan Ali (Khattak) wrote: > >> > >> One important thing I somehow did not realize before is the even with > >> approach#3, we'd need new API and apps will need to be changed so they > >> use the correct installer script. The new API would be: > >> > >> osinfo_os_get_install_script_list_for_variant(OsinfoOs *os, const char *variant) > >> osinfo_os_find_install_script_for_variant(OsinfoOs *os, const gchar > >> *profile, const char *variant) > >> > >> So I was thinking, if we are to add API for this and Apps have to > >> update their code anyway, why not implement a more generic solution > >> that allows us to keep the same script templates: > >> > >> * Add new API to pass media info (which includes variant info) to scripts: > >> > >> osinfo_install_script_generate_for_media(OsinfoInstallScript *script, > >> OsinfoOs *os, > >> > >> OsinfoMedia *media, ..) > > > > OsinfoMedia has an "os" property, so it's probably not required to make > > it explicit (it might only be set after a call to osinfo_identify_media > > though). Yes, the line above my answer is osinfo_install_script_generate_for_media(), so that method. The same most likely applies to the async variants and _output(). Christophe
Attachment:
pgpWlpUbHruDH.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
