Re: [PATCH 04/12] loader: Load volume-size for ISO9660 medias

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2015 at 9:57 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
> On Sun, Mar 15, 2015 at 04:04:51PM +0000, Zeeshan Ali (Khattak) wrote:
>> ---
>>  osinfo/osinfo_loader.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/osinfo/osinfo_loader.c b/osinfo/osinfo_loader.c
>> index 845eda3..4e8f942 100644
>> --- a/osinfo/osinfo_loader.c
>> +++ b/osinfo/osinfo_loader.c
>> @@ -999,7 +999,9 @@ static OsinfoMedia *osinfo_loader_media(OsinfoLoader *loader,
>>               strcmp((const gchar *)nodes[i]->name,
>>                      OSINFO_MEDIA_PROP_APPLICATION_ID) != 0 &&
>>               strcmp((const gchar *)nodes[i]->name,
>> -                    OSINFO_MEDIA_PROP_LANG) != 0))
>> +                    OSINFO_MEDIA_PROP_LANG) != 0 &&
>> +             strcmp((const gchar *)nodes[i]->name,
>> +                    OSINFO_MEDIA_PROP_VOLUME_SIZE) != 0))
>>              continue;
>>
>>          if (strcmp((const gchar *)nodes[i]->name,
>
> I'd squash the first patch (schema change) here as this is when we
> change the XML parsing to handle the new attribute.

Sure but then we'd need to add the API first and it seems weird for me
to do it in that sequence.

-- 
Regards,

Zeeshan Ali (Khattak)
________________________________________
Befriend GNOME: http://www.gnome.org/friends/

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux