Re: Volume-size patch series

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 16, 2015 at 09:56:24AM +0100, Fabiano Fidêncio wrote:
> Zeeshan,
> 
> On Sun, 2015-03-15 at 16:04 +0000, Zeeshan Ali (Khattak) wrote:
> > This series of patches,
> > 
> > 1. Makes it possible to specify volume-size for ISO media entries. 
> > 2. Make use of volume-size for detection. This is actually the main 
> > point of all this effort. Many times the volume-id is the same for 
> > different medias of the same OS and hence volume-id makes it much 
> > easier to differetiate between those different medias.
> > 3. Add volume-size info to fedora medias.
> > 4. Add many missing Fedora testcases.
> > 
> 
> Apart from a few details I've commented in a few specific patches, the 
> series looks good to me. However, I'd like you to wait for a Daniel's 
> review before pushing the patches.

With the changes already pointed out, I think this looks pretty good
and ready for merge.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo





[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux