Christophe Fergeau <cfergeau@xxxxxxxxxx> writes: > On Tue, Jul 29, 2014 at 03:41:08PM +0200, Giuseppe Scrivano wrote: >> Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx> >> --- >> cfg.mk | 1 - >> maint.mk | 2 +- >> 2 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/cfg.mk b/cfg.mk >> index c2f07e0..b9be881 100644 >> --- a/cfg.mk >> +++ b/cfg.mk >> @@ -21,7 +21,6 @@ local-checks-to-skip = \ >> makefile-check \ >> makefile_path_separator_check \ >> patch-check \ >> - sc_GPL_version \ >> sc_always_defined_macros \ >> sc_cast_of_alloca_return_value \ >> sc_cross_check_PATH_usage_in_tests \ >> diff --git a/maint.mk b/maint.mk >> index 04a839a..792100b 100644 >> --- a/maint.mk >> +++ b/maint.mk >> @@ -856,7 +856,7 @@ sc_prohibit_backup_files: >> >> # Require the latest GPL. >> sc_GPL_version: >> - @prohibit='either ''version [^3]' \ >> + @prohibit='either ''version [^23]' \ > > This one is weird, the comment implies that this test explicitly checks > that GPLv3 is used, and you change it to allow GPLv2 as well. What do we > get from this check in addition to the 'latest GPL' test? I've tried to enable as many rules as possible, but now that I think more about it, I agree with you, we can just drop this patch as there is not real advantage in having it. Thanks, Giuseppe _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
