On Wed, Jul 9, 2014 at 7:32 AM, Lasse Schuirmann <lasse.schuirmann@xxxxxxxxx> wrote: > 2014-07-08 21:08 GMT+02:00 Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx>: >> On Tue, Jul 8, 2014 at 2:35 PM, Lasse Schuirmann >> <lasse.schuirmann@xxxxxxxxx> wrote: >>> + <xsl:template name="target-disk"> >>> + <xsl:choose> >>> + <xsl:when test="config/target-disk != ''"> >>> + <xsl:value-of select="config/target-disk"/> >>> + </xsl:when> >>> + <xsl:otherwise> >>> + <xsl:text>/dev/vda</xsl:text> >> >> Shouldn't this be based on OS version, like in fedora's script? > > I wasn't able to grab an older debian ISO to test the script on them. > Despite of this, assuming this was necessary in fedora for some > specific changes they made from one version to the other, I don't see > any reason we'd need it for debian too. OK. >Target -disk is hard to guess > anyway because it hardly depends on the usage of the VM. You could > also use libosinfo for generating scripts for real machines, I assume > half of the installations would fail if you don't give target-disk > manually. While that is a valid usecase, the primary usecase is VMs. Lets keep it like this then. >>> + </xsl:otherwise> >>> + </xsl:choose> >>> + </xsl:template> >>> + >>> + <xsl:template name="l10n-language"> >>> + <xsl:choose> >>> + <xsl:when test="config/l10n-language != '' and config/l10n-language != 'C'"> >> >> * Don't we have the same issue in fedora and rhel scripts? > > I have not made much experience with the fedora scripts but I assume > that kickstart is designed to assume defaults if values are empty or > invalid. (At least I had no problems installing fedora and I had "C" > in there.) Preseed is just very bad at this, if anything is wrong with > the script it'll ask the user. OK. >> * It can be lowercase 'c' too: >> https://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Locale-Names.html > > Diddn't find the lowercase c on the page but it's no problem to add it. Never mind, the font is awful so it seemed like lower 'c'. Ignore this then. :) -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
