"Daniel P. Berrange" <berrange@xxxxxxxxxx> writes: > I'm surprised that osinfo_entity_get_type is soo high up there too. > Perhaps we do need to optimize that so we don't call it so frequently > during parsing. have you used this version of the series or v2? In v2 I've dropped the "osinfo_loader: avoid multiple calls to OSINFO_ENTITY" patch as it has not clear benefits on the wallclock but it reduces the calls to osinfo_entity_get_type. Callgrind says 273.345 calls vs 377.077, and it makes sense as we save 4 calls and it is iterated 25933 times. Should I reintroduce it? Regards, Giuseppe _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
