Hey,
Thanks for doing that! Regarding space/no space before '(', libosinfo is
indeed inconsistent. I was under the impression that we are meant to be
using space before '(' (ie the opposite of what your patch does).
As a matter of personal preference, I prefer no space, don't know what
others think.
Christophe
On Wed, Jun 04, 2014 at 11:50:52AM +0200, Giuseppe Scrivano wrote:
> Fix bracket spacing and enforce it with a new syntax rule (copied from
> libvirt).
>
> Giuseppe Scrivano (5):
> osinfo_loader: don't wrap return value with parentheses
> test: fix spacing to satisfy sc_bracket_spacing_check
> tools: fix spacing to satisfy sc_bracket_spacing_check
> osinfo: fix spacing to satisfy sc_bracket_spacing_check
> enforce bracket spacing with a syntax rule
>
> build-aux/bracket-spacing.pl | 162 +++++++++++++
> cfg.mk | 6 +
> osinfo/osinfo_avatar_format.c | 16 +-
> osinfo/osinfo_datamap.c | 18 +-
> osinfo/osinfo_datamaplist.c | 18 +-
> osinfo/osinfo_db.c | 48 ++--
> osinfo/osinfo_deployment.c | 28 +--
> osinfo/osinfo_deploymentlist.c | 18 +-
> osinfo/osinfo_device.c | 20 +-
> osinfo/osinfo_device_driver.c | 28 +--
> osinfo/osinfo_device_driverlist.c | 18 +-
> osinfo/osinfo_devicelink.c | 24 +-
> osinfo/osinfo_devicelinkfilter.c | 26 +--
> osinfo/osinfo_devicelinklist.c | 20 +-
> osinfo/osinfo_devicelist.c | 18 +-
> osinfo/osinfo_entity.c | 44 ++--
> osinfo/osinfo_filter.c | 22 +-
> osinfo/osinfo_install_config.c | 14 +-
> osinfo/osinfo_install_config_param.c | 24 +-
> osinfo/osinfo_install_config_paramlist.c | 18 +-
> osinfo/osinfo_install_script.c | 28 +--
> osinfo/osinfo_install_scriptlist.c | 18 +-
> osinfo/osinfo_list.c | 24 +-
> osinfo/osinfo_loader.c | 116 +++++-----
> osinfo/osinfo_media.c | 382 +++++++++++++++----------------
> osinfo/osinfo_medialist.c | 18 +-
> osinfo/osinfo_os.c | 84 +++----
> osinfo/osinfo_os_variant.c | 48 ++--
> osinfo/osinfo_os_variantlist.c | 12 +-
> osinfo/osinfo_oslist.c | 18 +-
> osinfo/osinfo_platform.c | 20 +-
> osinfo/osinfo_platformlist.c | 18 +-
> osinfo/osinfo_product.c | 138 +++++------
> osinfo/osinfo_productfilter.c | 24 +-
> osinfo/osinfo_productlist.c | 18 +-
> osinfo/osinfo_resources.c | 178 +++++++-------
> osinfo/osinfo_resourceslist.c | 18 +-
> osinfo/osinfo_tree.c | 12 +-
> osinfo/osinfo_treelist.c | 22 +-
> test/test-db.c | 18 +-
> test/test-device.c | 12 +-
> test/test-devicelist.c | 18 +-
> test/test-entity.c | 16 +-
> test/test-filter.c | 12 +-
> test/test-install-script.c | 24 +-
> test/test-isodetect.c | 12 +-
> test/test-list.c | 26 +--
> test/test-loader.c | 12 +-
> test/test-mediauris.c | 18 +-
> test/test-os.c | 12 +-
> test/test-oslist.c | 18 +-
> test/test-platform.c | 14 +-
> test/test-platformlist.c | 18 +-
> test/test-product.c | 16 +-
> test/test-productfilter.c | 16 +-
> test/test-treeuris.c | 18 +-
> tools/osinfo-db-validate.c | 8 +-
> tools/osinfo-detect.c | 14 +-
> tools/osinfo-install-script.c | 8 +-
> tools/osinfo-query.c | 24 +-
> 60 files changed, 1144 insertions(+), 976 deletions(-)
> create mode 100755 build-aux/bracket-spacing.pl
>
> --
> 1.9.3
>
> _______________________________________________
> Libosinfo mailing list
> Libosinfo@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/libosinfo
Attachment:
pgprPzqnxCoT5.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
