On Wed, May 14, 2014 at 6:07 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Wed, May 14, 2014 at 03:59:32PM +0100, Zeeshan Ali (Khattak) wrote: >> Actually, i hardcoded 'fr_CA' to be passed as I didn't think hard >> enough that its not going to actually happen. Sorry about the false >> alarm. :( Thinking about this, I wonder why en_GB gets passed. > > There are some en-gb win7 ISOs, this probably comes from these. And your > fr_CA experiments are another indication that noone reads API doc about > valid values, and that it would be much easier if the install scripts > parameters could be validated by libosinfo before being used ;) Imo it's > a good experiment with what users of libosinfo could go through :( There is a GError parameter to osinfo_install_script_generate* so we could check the params in there but that easy for generic stuff (e.g hostname) but in this case, we'd need some new xml at least (if not, API). -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
