On Tue, May 13, 2014 at 10:20 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Mon, May 12, 2014 at 04:38:34PM +0100, Zeeshan Ali (Khattak) wrote: >> Since 'ComputerName' is supposed to be max 15 characters, unattended >> installation breaks if this is set to a string longer than that. Lets crop the >> string to ensure that doesn't happen. >> >> http://technet.microsoft.com/en-us/library/ff715676.aspx > > This link also lists forbidden characters, I don't think this is > enforced? No its not. I didn't bother to enforce that (read below). > I'm also not sure substring will do the right thing with > non-ASCII characters, which are potentially encoded as multiple bytes > (the limit is 15 bytes, not 15 chars). That is true. Either I go work on my XSLT-foo and enforce this or we can just document this in set_hostname. Reading this, I'd go for the latter as non-ASCII won't be acceptable on other OSs either: https://en.wikipedia.org/wiki/Hostname#Restrictions_on_valid_host_names -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
