On Thu, Apr 24, 2014 at 2:05 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > > ----- Mail original ----- >> In commit 39f22d2 (win7: Generalize volume-id for professional), I >> generalized the regex of windows 7 professional to include N SP1 but I >> ended up adding the regex for both i386 and x86_64 architectures under >> i386. >> >> This patch fixes that. >> > > On second though, I'd probably not use a regex at all, but explicitly list every variant. Or we can start trying to decipher the label, I'm fairly sure all volume IDs can be generated using a few regexp. I'd rather we go for the latter approach. We decided to use regex for a reason. -- Regards, Zeeshan Ali (Khattak) ________________________________________ Befriend GNOME: http://www.gnome.org/friends/ _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
