On Thu, Mar 20, 2014 at 4:09 PM, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: > "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> writes: > >>> However, I'm not familiar enough with the implications of using >>> this 'raw' node API to feel comfortable ACKing this :-/ >> >> Looking at the docs, it should be fine. Giuseppe, I assume you ensured >> `make check` doesn't break with this? > > yes, sure: > > $ git log --oneline -1 > 5d53e18 osinfo-install-script: read config values as strings > > $ make -C test check > > [......] > > ============================================================================ > Testsuite summary for libosinfo 0.2.9 > ============================================================================ > # TOTAL: 18 > # PASS: 16 > # SKIP: 2 > # XFAIL: 0 > # FAIL: 0 > # XPASS: 0 > # ERROR: 0 > ============================================================================ Cool, ACK then. Will push it soon. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
