On Mon, Mar 10, 2014 at 11:00 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote: > > > > On Mon, Mar 10, 2014 at 11:37 PM, Zeeshan Ali (Khattak) > <zeeshanak@xxxxxxxxx> wrote: >> >> On Sun, Mar 9, 2014 at 6:23 PM, Zeeshan Ali (Khattak) >> <zeeshanak@xxxxxxxxx> wrote: >> > On Sun, Mar 9, 2014 at 12:36 PM, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> >> > wrote: >> >> "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> writes: >> >> >> >>> While I was about to push these patches on behalf of Guiseppe, I >> >>> realized some things that could be improved in the api: >> >>> >> >>> * 'The 'supported/SUPPORTED' part of these API seems very redundant >> >>> and makes identifiers way too long. >> >>> * get_injection_method should be plural form: get_injection_methods. >> >>> >> >>> These patches fixes/improves these issues. >> >> >> >> thanks for these fixes. I've tested these changes again trough the >> >> Python binding and they seem to work as expected. >> > >> > Cool, thanks for testing. >> > >> >> Is something more >> >> holding this series? >> > >> > No, just need an ACK after my changes. :) >> >> And still need it btw. :) > > > "I've tested these changes again trough the > Python binding and they seem to work as expected". > > So, go ahead and push it. All pushed! -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
