Hi, Apart from some nitpicks below, looks good. ACK with or without suggested changes. On Wed, Mar 5, 2014 at 3:01 PM, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote: > The API allows to query how it is possible to use the script from the > installation process. Sounds a bit vague. "use the script from the installation process" -> "inject the script into the installation process"? 'it is possible' part is redundant IMO. > @@ -1309,6 +1309,24 @@ int osinfo_install_script_get_post_install_drivers_signing_req(OsinfoInstallScri > OSINFO_DEVICE_DRIVER_SIGNING_REQ_NONE); > } > > +/** > + * osinfo_install_script_get_supported_injection_method: > + * @script: the install script > + * > + * Retrieve how it is possible to inject the script in the installation process. "is is possible" part redundant here too. _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
