Re: [PATCH v3 6/7] get-supported-injection-method: update Fedora install scripts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



"Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> writes:

> On Fri, Feb 28, 2014 at 1:05 PM, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote:
>> Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx>
>> ---
>
> Same comment about short log as for windows patch.
>
>>  data/install-scripts/fedora.xml | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/data/install-scripts/fedora.xml b/data/install-scripts/fedora.xml
>> index 0a5de10..4507e77 100644
>> --- a/data/install-scripts/fedora.xml
>> +++ b/data/install-scripts/fedora.xml
>> @@ -11,6 +11,10 @@
>>        <param name="target-disk" policy="optional"/>
>>        <param name="script-disk" policy="required"/>
>>      </config>
>> +    <supported-injection-method>cdrom</supported-injection-method>
>> +    <supported-injection-method>floppy</supported-injection-method>
>> +    <supported-injection-method>initrd</supported-injection-method>
>> +    <supported-injection-method>web</supported-injection-method>
>
> You never answered my question about how this affects commandline
> generation. The one we have right now assumes the script to be a disk,
> rather than initrd or web so at least currently I'd say these two
> methods are not supported and therefore should not be listed here.

ops, sorry, now I understand what you mean with "commandline
generation".  I've missed this part, and as I commented for Debian and
Ubuntu patches, they need a command line to work.

Giuseppe

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux