On Fri, Feb 28, 2014 at 1:05 PM, Giuseppe Scrivano <gscrivan@xxxxxxxxxx> wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx>
> ---
The name of method is get_supported_injection_method, contrary to what
shortlog is saying. Also, would be nice to have some more description
here about this change.
One small comment below but otherwise look good, although I would have
divided this patch a bit more but thats just my perfectionism. :)
> @@ -113,6 +114,25 @@ typedef enum {
> OSINFO_DEVICE_DRIVER_SIGNING_REQ_WARN
> } OsinfoDeviceDriverSigningReq;
>
> +/**
> + * OsinfoInstallScriptSupportedInjectionMethod:
> + *
> + * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_CDROM: Support injection of the
> + * installation script to a CD-ROM.
> + * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_FLOPPY: Support injection of the
> + * installation script to a floppy disk.
> + * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_INITRD: Support injection of the
> + * installation script to the initrd.
'to' -> 'through' in all three sentences above.
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo
