On Wed, Dec 18, 2013 at 04:30:53PM +0100, Christophe Fergeau wrote: > On Wed, Dec 18, 2013 at 04:18:44PM +0100, Christophe Fergeau wrote: > > From: Ryan Lortie <desrt@xxxxxxxx> > > > > Switch to using the upstream m4 macros for GObject-introspection > > integration. > > > I guess Giuseppe concerns still apply, see > https://www.redhat.com/archives/libosinfo/2013-December/msg00053.html > (and mine too https://www.redhat.com/archives/libosinfo/2013-December/msg00060.html > ;). Any thoughts on that? I don't think we need this to be conditional as we're not targetting RHEL6 systems with libosinfo. The README already mentions the need for gobject-introspection as an optional dep. I'm just going to push this patch since IMHO it is fine as is. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo