Hey, On Thu, Apr 04, 2013 at 02:07:32AM +0300, Zeeshan Ali (Khattak) wrote: > I got this patch from Samuli. Christophe already took care of DESDIR > issue so that part is not needed at least but is the mkdir part > needed? I could not hit an issue with the missing mkdir. The rules in all of the data subdirs will create the db/ directory, but if we try to create the symlinks before any of the subdirs is processed (which I guess can happen in parallel builds) then this will be an issue. Christophe > > > ---------- Forwarded message ---------- > From: Samuli Suominen <ssuominen@xxxxxxxxxx> > Date: Sat, Mar 30, 2013 at 8:45 PM > Subject: [patch] libosinfo-0.2.6 has wrong $(DESTDIR) handling and > breaks installation on package managers > To: zeeshanak@xxxxxxxxx, berrange@xxxxxxxxxx > > > 2 problems: > > - /usr/share/libosinfo/db is not created when required > - $(DESTDIR) is not used when symlinking the pci.ids, usb.ids > > I hope this mail is enough. No credits required. Just push the patch > if you can, thank you! > > - Samuli Suominen > > > -- > Regards, > > Zeeshan Ali (Khattak) > FSF member#5124 > --- data/Makefile.am > +++ data/Makefile.am > @@ -11,7 +11,8 @@ > -wget -q -O $@ http://www.linux-usb.org/usb.ids > else > usb_ids_install: > - $(LN_S) $(USB_IDS) $(pkgdatadir)/db/usb.ids > + -mkdir -p $(DESTDIR)$(pkgdatadir)/db/ > + $(LN_S) $(USB_IDS) $(DESTDIR)$(pkgdatadir)/db/usb.ids > INSTALL_DATA_HOOK_DEPS += usb_ids_install > endif > > @@ -22,7 +23,8 @@ > -wget -q -O $@ http://pciids.sourceforge.net/v2.2/pci.ids > else > pci_ids_install: > - $(LN_S) $(PCI_IDS) $(pkgdatadir)/db/pci.ids > + -mkdir -p $(DESTDIR)$(pkgdatadir)/db/ > + $(LN_S) $(PCI_IDS) $(DESTDIR)$(pkgdatadir)/db/pci.ids > INSTALL_DATA_HOOK_DEPS += pci_ids_install > endif > > _______________________________________________ > Libosinfo mailing list > Libosinfo@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/libosinfo
Attachment:
pgpsHt9B3CniD.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
