On Tue, Apr 02, 2013 at 11:23:33AM -0600, Eric Blake wrote: > On 04/02/2013 10:46 AM, Daniel P. Berrange wrote: > > From: "Daniel P. Berrange" <berrange@xxxxxxxxxx> > > > > Every source file is currently built twice by libtool, once for > > the shared library and once for the static library. Static libs > > are not commonly packaged by distros and slow down compilation > > time by almost 100% compared to a shared-only build time. > > > > Time for non-parallel make > > > > shared only: 22 secs > > shared + static: 40 secs > > > > Those few people who really want them, can pass --enable-static > > to configure > > > > Disabling them by default requires use of LT_INIT. We don't need > > to support older libtool, so drop use of AM_PROG_LIBTOOL entirely > > --- > > configure.ac | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > --- > > configure.ac | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > Odd double-diffstat. But looks like you are on a roll, doing the same > cleanup throughout the virt stack :) > > > +++ b/configure.ac > > @@ -5,10 +5,11 @@ AM_INIT_AUTOMAKE([1.11.1 foreign color-tests tar-ustar]) > > AC_PREREQ([2.61]) > > AC_CONFIG_SRCDIR([osinfo/osinfo_db.c]) > > AC_CONFIG_HEADERS([config.h]) > > -AC_PROG_LIBTOOL > > AC_PROG_CC > > AC_PROG_LN_S > > > > +LT_INIT([shared disable-static win32-dll]) > > Where did win32-dll come from for this particular configure.ac? We > weren't previously using AC_LIBTOOL_WIN32_DLL. > > ACK if you drop the unneeded option. Actually, we should have had that all along - we're building DLLs as part of the autobuild process ! Not sure why we didn't have trouble without it though ! Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
