Hey Michal, On Mon, Feb 04, 2013 at 09:01:11AM +0100, Christophe Fergeau wrote: > On Fri, Feb 01, 2013 at 03:19:59PM +0100, Michal Privoznik wrote: > > The code looks okay, but why do we have these variable if they are not > > used anywhere? > > I must say that I initially chose not to look at why in details as I worked > on the assumption that the warnings had been worked around for a good > reason. > Looking at this a bit more, they happen in the code parsing the > pciids/usbids files, and we need to skip these values in the file during > parsing, having a name for them makes the code more readable, and easier > to extend later if we need these, so I'd be in favour of keeping them. Did that address your concerns? Or was your previous email to be considered as an ACK? Christophe
Attachment:
pgpPzRjMsRAP0.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
