On Mon, Jan 28, 2013 at 04:51:04PM +0200, Zeeshan Ali (Khattak) wrote:
> On Mon, Jan 28, 2013 at 12:48 PM, Christophe Fergeau
> <cfergeau@xxxxxxxxxx> wrote:
> > On Mon, Jan 28, 2013 at 05:18:45AM +0200, Zeeshan Ali (Khattak) wrote:
> >> +/**
> >> + * osinfo_install_script_get_can_post_install_unsigned_drivers:
> >> + * @script: the install script
> >> + *
> >> + * If install script can install drivers at the end of installation, this
> >> + * function can be used to query if it can handle unsigned drivers.
> >
> > All of this is a bit vague to me, this seems more tri-state than just a
> > boolean, most Windows will warn when trying to install unsigned-by-MS
> > drivers but will let you go through after saying you are ok with installing
> > this driver. Starting with win7 64 bit, the OS will refuse to install the
> > drivers without letting you click your way around it.
> > This commit seems to assume that 'having to click' = 'cannot post install
> > the driver'. While inconvenient during post-install, I can see this being
> > better than nothing to some libosinfo users.
>
> While in Boxes, we certainly wouldn't want a warning message as it
> breaks the whole concept of express installation, I guess other apps
> could be given a choice here.
>
> How about an enum like this:
>
> enum DeviceDriverSignReq {
> DEVICE_DRIVER_SIGN_REQ_STRICT, /* Script must only be given signed
> device drivers. */
> DEVICE_DRIVER_SIGN_REQ_WARN, /* A warning will be issued by OS
> installer if device drivers are not signed. */
> DEVICE_DRIVER_SIGN_REQ_NONE, /* Script do not require device drivers
> to be signed. */
> }
I'd change 'Sign' to 'Signing', and make it explicit that the 'REQ_WARN'
case can break unattended installation and require user input. Same for
'REQ_STRICT' actually, in addition to not installing unsigned drivers,
passing an unsigned driver may also break unattended install (?)
Christophe
Attachment:
pgp2pSyICVZ7v.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
