On Wed, Jan 9, 2013 at 6:10 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: >> As for the throw-away copy, I'm also all for getting rid of it, it >> was added after I got an objection during review. The code was initially >> doing a straight g_object_set(config, "config-params", params, NULL); >> during the generation of the install script instead of a copy. > > I think that would be a bad - as a user of this API, I'd really not be > expecting it to modify the InstallConfig instance I pass in - it should > be considered 'const' IMHO. I fully agree. Hence the reason I suggested on the throw-away copy. Probably didn't think of the fact that we can transform without doing so. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
