Re: [PATCH] configure: Use LINGUAS file

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 02, 2013 at 06:45:31PM +0200, Zeeshan Ali (Khattak) wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
> 
> Setting ALL_LINGUAS in configure.in is obsolete according to po.m4 in
> favor of LINGUAS file. This is the reason why all (as far as I can see)
> GNOME modules use LINGUAS file.
> 
> Also the rule in configure.ac creates broken Makefile if there is more
> than one translation files:
> 
> [zeenix@z-laptop libosinfo]$ make
> Makefile:166: *** missing separator.  Stop.
> [zeenix@z-laptop libosinfo]$ head -n 166 Makefile|tail -n 2
> ALL_LINGUAS = pl
> uk
> ---
>  configure.ac | 2 --
>  po/LINGUAS   | 0
>  2 files changed, 2 deletions(-)
>  create mode 100644 po/LINGUAS
> 
> diff --git a/configure.ac b/configure.ac
> index ade0ee7..f4b1044 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -21,8 +21,6 @@ AC_DEFINE_UNQUOTED([GETTEXT_PACKAGE],["$GETTEXT_PACKAGE"],[The name of the gette
>  AM_GNU_GETTEXT([external])
>  AM_GNU_GETTEXT_VERSION([0.17])
>  
> -ALL_LINGUAS=`cd "$srcdir/po" > /dev/null && ls *.po | sed 's+\.po$++'`
> -
>  # Autoconf 2.61a.99 and earlier don't support linking a file only
>  # in VPATH builds.  But since GNUmakefile is for maintainer use
>  # only, it does not matter if we skip the link with older autoconf.
> diff --git a/po/LINGUAS b/po/LINGUAS
> new file mode 100644
> index 0000000..e69de29

ACK

Don't forget to actually populate LINGUAS when you pull in new xlations.

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux