On Thu, Dec 27, 2012 at 3:09 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Thu, Dec 27, 2012 at 02:55:04PM +0200, Zeeshan Ali (Khattak) wrote: >> On Sun, Dec 23, 2012 at 7:15 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: >> > clearparts is the only command still trying to use target-disk, >> > my guess is that this should be hardcoded to be done on the first disk some >> > how, and 'target-disk' should never appear in this script. >> >> I don't think thats wise. RHEL 7.x will most likely support disk >> arguments to 'part' commands (as Fedora17-18 supports it) and we >> can't have conditions on configuration parameters but only on their >> usage in the templates. > > Well, solve this the way you want, but having target-disk used only with > clearparts in the script is wrong. Its not exactly wrong. RHEL won't be the first one to assume a particular disk to be for a particular purpose: windows xp (and IIRC win7) also assume installer disk to be the floppy drive, yet we provide apps to specify installer disk. In these cases, its more like a way for apps to tell us what that disk is as hard coding the values aren't as easy as it sounds. E.g in case of Linux, first hard disk can be sda, sda1, hda, hdb etc etc. We should specify in the docs these limitations though, like we do for Windows XP in osinfo_install_config_set_pre_install_drivers_disk docs. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
