On Thu, Dec 27, 2012 at 11:03 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > On Thu, Dec 27, 2012 at 10:23:10PM +0200, Zeeshan Ali (Khattak) wrote: >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> >> >> Using the desktop profile, I was able to do an express installation >> against GNOME Boxes. >> >> I'm adding a seperate script for windows 8 rather than re-using the >> existing unattended.xml we have for windows 7 because windows 8 requires >> product key to be specified while it remains option for windows 7. > > You make it sound like 99% of the file is duplicated expect for this > optional/required product key. Other differences can be covered with conditions, paramets can't (at least not currently) so other differences are irreverent here unless they were plenty of them. > Could we avoid this duplication through some > XML includes? Surely would be nicer that way but doesn't have to be part of this patch (?). Would also avoid duplication between the two profiles btw. >> + <xsl:template name="language"> >> + <xsl:variable name="language"> >> + <xsl:value-of select="config/l10n-language"/> >> + </xsl:variable> >> + <xsl:variable name="formatted-language"> >> + <xsl:value-of select="translate($language,'_','-')"/> >> + </xsl:variable> >> + <xsl:choose> >> + <xsl:when test="contains($formatted-language,'.')"> >> + <xsl:value-of select="substring-before($formatted-language,'.')"/> >> + </xsl:when> >> + <xsl:otherwise> >> + <xsl:value-of select="$formatted-language"/> >> + </xsl:otherwise> >> + </xsl:choose> >> + </xsl:template> > > Would be a good opportunity to follow up on > https://www.redhat.com/archives/virt-tools-list/2012-December/msg00160.html That was for Fedora's keyboard and I'm already on that but yeah, if datamaps could be used for Fedora's keyboard, it can probably be used for this one as well. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 _______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
