On Sun, Dec 23, 2012 at 3:47 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote:
> On Sat, Dec 22, 2012 at 5:37 PM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote:
>> On Sat, Dec 22, 2012 at 1:01 PM, Zeeshan Ali (Khattak)
>> <zeeshanak@xxxxxxxxx> wrote:
>>> On Sat, Dec 22, 2012 at 7:26 AM, Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> wrote:
>>>> On Sat, Dec 22, 2012 at 2:20 AM, Zeeshan Ali (Khattak)
>>>> <zeeshanak@xxxxxxxxx> wrote:
>>>>> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
>>>>>
>>>>> The same script might work for other versions too but I have only made
>>>>> it work against RHEL 6.3 for now. Still some issues though:
>>>>>
>>>>> 1. For some reason user's avatar is ignored although according to the docs
>>>>> I could find*, copying the avatar to /home/${USER}/.face should be
>>>>> enough.
>>>>>
>>>>> 2. We don't set the keyboard layout properly yet and just hardcode it to
>>>>> 'us'. This will require the same kind of mapping as Fedora 17 and older.
>>>>>
>>>>> * http://projects.gnome.org/gdm/docs/2.14/configuration.html
>>>>
>>>> What is the idea? Push this commit and fix these issues later?
>>>
>>> Yeah, this is meant to be a starting point. Our existing scripts are
>>> not perfect either (e.g windows script don't set keyboard).
>>
>> I agree, in parts, with your argument.
>> I don't have bad feelings about the patch, so, ACK!
>
> Ah! Downloading a CentOS to test your patches, I realized that you
> forgot to add the installer node in data/oses/rhel.xml.in
No, I didn't. Read the end of my patch. :)
--
Regards,
Zeeshan Ali (Khattak)
FSF member#5124
_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo
