On Tue, Dec 18, 2012 at 04:45:15PM +0200, Zeeshan Ali (Khattak) wrote:
> On Tue, Dec 18, 2012 at 12:05 PM, Christophe Fergeau
> <cfergeau@xxxxxxxxxx> wrote:
> > Yup, I've thought of both, we can also do if (config == entity) {}, but I
> > preferred to go the explicit way since the caller knows what it wants us to
> > do.
>
> Caller knows what it is passing and callee has easy ways to find out
> the type so why would you need this extra parameter? You are not
> making anything more explicit either in the caller or callee
> functions. Sorry but this just looks very clumsy.
Callee has an easy way to _guess_ how it was called by harcoding checks for
something that is true the way the code is _now_, this assumption could
easily break with some future changes. I'm fine with changing to a runtime
type check, but I don't see this as an improvement, just clumsy in a
different way.
Christophe
Attachment:
pgppVOHTVnEM0.pgp
Description: PGP signature
_______________________________________________ Libosinfo mailing list Libosinfo@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/libosinfo
