Re: [PATCHv4 06/11] Add OsinfoInstallConfig:config-params property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 18, 2012 at 03:42:17AM +0200, Zeeshan Ali (Khattak) wrote:
> On Tue, Dec 18, 2012 at 3:13 AM, Zeeshan Ali (Khattak)
> <zeeshanak@xxxxxxxxx> wrote:
> > On Mon, Dec 17, 2012 at 11:07 PM, Christophe Fergeau
> > <cfergeau@xxxxxxxxxx> wrote:
> >> This property lists the parameters that can be set for a given
> >> OsinfoInstallConfig. This is not enforced, it's only there for
> >> informative purpose. This will also be used in later commits
> >> in order to automatically apply transformations on values
> >> for parameters which have an associated OsinfoDatamap.
> >
> > Since there is already a very similar property in OsinfoInstallScript,
> > I'm afraid this will cause confusion for app developers. Is there no
> > way we can achieve the same goals through the existing API?
> 
> Later commits clarifies things quite a bit so take that comment as:
> Perhaps this should be internal API?

I assume you are talking about osinfo_install_config_get_config_params
and osinfo_install_config_set_config_params as the GObject property can't
really be made private? I _think_ this API could be useful as a public API,
but I'm fine with making it private for now and exporting it when we see a
real need for it.

Christophe

Attachment: pgpTzH2kVexPP.pgp
Description: PGP signature

_______________________________________________
Libosinfo mailing list
Libosinfo@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/libosinfo

[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Fedora Users]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux