On Mon, Dec 17, 2012 at 11:07 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > Now that OsinfoInstallConfig has access to the > OsinfoInstallConfigParamList for the OsinfoInstallScript that is > being configured, In the previous patch (06/11) you just added the setter/getter for config params to OsinfoInstallConfig but nothing yet sets the params. Either I'm totally confused or the ordering of these patches is somehow wrong. > we can use the OsinfoDatamap that is optionally > set on a given parameter to automatically translate a value for > this parameter from a generic libosinfo value to an OS-specific one. Assuming config params in OsinfoInstallScript has (or can has) access to datamaps, I wonder if there is any need to involve OsinfoInstallConfig at all here. The changes will be less intrusive that way AFAICT. -- Regards, Zeeshan Ali (Khattak) FSF member#5124