On Fri, 2010-10-15 at 14:24 -0400, seth vidal wrote: > On Fri, 2010-10-15 at 14:14 -0400, "S.ÃaÄlar Onur" wrote: > > Hi, > > > > On Oct 15, 2010, at 2:07 PM, seth vidal wrote: > > > > > On Fri, 2010-10-15 at 14:03 -0400, "S.ÃaÄlar Onur" wrote: > > >> Hey Seth, > > >> > > >> While you are here are you interested with something like this? It changes files to use 4-space indents and no hard tab characters. Also trim excess spaces and tabs from ends of lines, and remove empty lines at the end of files and ensure the last line ends with a newline. > > >> > > > > > > > > > I had cleaned up some of them - can you check to merge vs the ones I > > > checked in. > > > > That patch was against the current git (commit a9ecc9d3f9d08115f4c548d76851d8554f49a248). > > > > > and yes - in general stabbing anything using non-4space indents and > > > real-tabs is acceptable. > > > > > > I don't mind whitespace on the end of the line much but that's b/c it > > > doesn't actually make the code unreadable. > > > > OK, I uploaded it to [1] (its ~400K) to let you give an eye to it. I'm planning to commit it after your ACK :) > > > > [1] http://www.cs.princeton.edu/~caglar/whitespace.patch > > > > > ugh. Can you revert the end-of-line-white-space-removal so I can diff it > against the rest. > > It's REALLY hard to read 400K of patches in one go. > Okay - I take that back. ACK to your patch - go ahead and commit it. and if you have time - run some git blames and find out who we get to mock for 3-space indents.. :) -sv _______________________________________________ Func-list mailing list Func-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/func-list
