Hi Seth, On Aug 10, 2010, at 2:02 PM, seth vidal wrote: > If you remove the minions attribute creation there - how does the above > section of code not ALWAYS fail or at least traceout? > You are right and that version is the wrong one which contains some syntax errors as well, please see attached one. >> +def extend_hostname_to_fqdn(hostname): >> + try: >> + (fqdn, aliases, ips) = socket.gethostbyname_ex(hostname) >> + except socket.gaierror, e: >> + return (hostname, []) >> + else: >> + return (fqdn, aliases) >> >> def get_fresh_method_instance(function_ref): >> """ > > Not sure I'm in love with how extend_hostname_to_fqdn() works - the > trick is to assume that whatever we're handed is _something_ valid - and > also to not assume that what is NOW the fqdn was always the fqdn. > > -sv
Attachment:
func.patch
Description: Binary data
Best regards, -- S.Çağlar Onur <caglar@xxxxxxxxxxxxxxxx>
_______________________________________________ Func-list mailing list Func-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/func-list
