On Wed, Mar 26, 2008 at 6:12 AM, Luca Foppiano <lfoppiano@xxxxxxxxxxxxx> wrote: > > + return "version" Shouldn't this be return version, without quotes? > + for items in results: > + if "-Dprogram.name=run.sh" in items: Ug. > + def search_by_address(self, address, status=None): > + """ > + Search istance by bind address This should be "instance", no? (And all the other occurences) > + arguments = boss_run_path+" -c "+istance+" -b "+address > + cmd = sub_process.Popen(["/bin/sh", arguments], > executable="/bin/sh", > + stdout=sub_process.PIPE, > + stderr=sub_process.PIPE, > + shell=False) I guess Func is trying to target Python 2.3, but what I would do is pull subprocess.py into the distribution (works fine on 2.3), and use it. It's pretty much always wrong to invoke processes using /bin/sh. > + arguments = " -s jnp://"+address+":1099" So wait, we hardcode the JNP port? If we're not trying to support different port numbers, why go to all the trouble of trying to detect the bind address? Can't we just issue a twiddle.sh command directly? _______________________________________________ Func-list mailing list Func-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/func-list
