On Tue, 2007-12-04 at 10:20 -0500, Michael DeHaan wrote: > James Antill wrote: > > Currently: > > > > func '*' show hardware > > > > ...shows nothing, attached patch fixes it via. brute force. > > You can also pull from http://people.redhat.com/jantill/gits/func > > > James, > > I ran into the problem with "show hardware" not showing anything without > options before, but removing the > code to do selective showings "--os" is probably not right either. I didn't remove the code to do selective options, "func '*' show --memory" etc. all work as they did before. Just that get_option() always returns true, even if you don't specify an option ... so I removed the tests using that to see if any options had been set. > Perhaps you could tweak it to default to "--help" if no options are > supplied? Well there's a _lot_ of info. that is returned by "show hardware" that isn't one of the three options it currently has. Maybe changing the interface to: func '*' show hardware os func '*' show hardware systemMemory func '*' show hardware systemSwap ...etc. to get specific information, if you want I can do a patch for that today? -- James Antill <james@xxxxxxxxxxxxxxxxx>
