Re: next update broke my bridge again

[Francis.Montagnac@xxxxxxxx]

Hi.

On Mon, 01 May 2023 00:22:38 -0700 ToddAndMargo via users wrote:

> nmcli device show br0 > /dev/nul

Beware: /dev/null, not /dev/nul

> if [ $? = 0 ]; then
>      InternalNic=br0

> else
>      InternalNic=eno1
> fi

> internal_addr=$(nmcli device show $InternalNic | grep -i 
> 'IP4.ADDRESS\[1\]' | grep 1 | awk '{print $2}' | sed -e 's/\/.*//')

That could be simplified as follows:
(not using $?, using awk instead of grep & sed)

    if nmcli device show br0 > /dev/null; then
         InternalNic=br0
     else
         InternalNic=eno1
    fi

    internal_addr=$(
      nmcli device show $InternalNic \
        | awk -F'[ /]+' '$1 == "IP4.ADDRESS[1]:" { print $2 }'
      )

or even simpler by using nmcli --get-values and assuming you have only
one IP address on this interface:

    internal_addr=$(nmcli --get-values IP4.ADDRESS device show $InternalNic)
    internal_addr=${internal_addr%/*}

-- 
francis
_______________________________________________
users mailing list -- users@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to users-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/users@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue