On Mon, 27 Jun 2016 10:56:52 -0500 Ranjan Maitra <maitra.mbox.ignored@xxxxxxxxx> wrote: > On Sun, 26 Jun 2016 23:35:39 +0200 Michael Schwendt > <mschwendt@xxxxxxxxx> wrote: > > > On Sun, 26 Jun 2016 12:44:59 -0500, Ranjan Maitra wrote: > > > > > > Revisit the build output and look for a real error message from > > > > the compiler, not these that Make prints. > > > > > > Where is this build output? I get the following complete output > > > when I use: > > > > Here: > > > > > ../src/core/Main.cc:84:35: error: invalid suffix on literal; > > > C++11 requires a space between literal and string macro > > > [-Werror=literal-suffix] command = PACKAGE_NAME" "DEFAULT_ARGV; > > > > And the line above that is the full invocation of the compiler. > > I don't get an error when I try compiling on the commandline. > > Here is what I try (as per the INSTALL file): > > ./configure > make > make check > > All of them pass (absolutely no errors or warnings!). So, is there > something wrong with my spec file which gets me the above error? > > I have uploaded my SPEC file here (again): > > http://paste.fedoraproject.org/385559/46704294 The error is very clear. The C++ standard that rpmbuild uses as its default (C++ 11?), detects an error in the file main.c at line 84, character 35. When you use the command line, you are probably defaulting to an earlier standard that accepted this. IIRC, a new standard also came out last year or the year before. C++ 14 or 15. I don't use c++ a lot, but I recall that there is an option you can set to specify the version to use. If you use info gcc (or the friendlier pinfo gcc), you can track it down, and then put it into your spec file as part of the gcc options. I *think* that is called C++-OPTIONS in spec files. Or, you can create a patch to fix the main file by adding the space it is asking for, add it to the spec file, and also send it upstream. Since the fix appears trivial, the second is probably the better path to follow, as it future proofs the code. -- users mailing list users@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe or change subscription options: https://lists.fedoraproject.org/admin/lists/users@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct Guidelines: http://fedoraproject.org/wiki/Mailing_list_guidelines Have a question? Ask away: http://ask.fedoraproject.org
