Hedayat Vatankhah schrieb: > Hi all, > > I've just submitted my review request for rcssserver3d package: > > https://bugzilla.redhat.com/show_bug.cgi?id=450409 Great! I've compiled the package and got some errors: - Unpackaged file /usr/bin/rcssmonitor3D-lite, after adding this to the %files section I could build it. - The devel packages triggers rpmlint warnings which have to be fixed: # rpmlint rcssserver3d-devel-0.5.9-1.fc9.x86_64.rpm rcssserver3d-devel.x86_64: W: no-documentation rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/libsalt.so libsalt.so.0.3.1 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/libspark.so libspark.so.0.0.0 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/librcssmonitor3D.so librcssmonitor3D.so.1.1.0 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/liboxygen.so liboxygen.so.3.2.3 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/libkerosin.so libkerosin.so.1.0.1 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/libzeitgeist.so libzeitgeist.so.3.0.1 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/libtinyxml.so libtinyxml.so.0.0.0 rcssserver3d-devel.x86_64: W: dangling-relative-symlink /usr/lib64/rcssserver3d/librcssnet3D.so librcssnet3D.so.0.0.0 rcssserver3d-devel.x86_64: E: only-non-binary-in-usr-lib - You should consider splitting the patch in one GCC4.3 and one rpath patch - You are a rcssserver3d committer, right? So why not commit the fixes and build a package from SVN? - The patches seem to contain changes besides fixing rpath and GCC 4.3, are these changes necessary? Should be a separate patch then. - The explicit requires on the libraries shouldn't be necessary, rpmbuild should be able to figure them out automatically - What do you mean by comment 4, the "included some so files". What are these .so files? If these libraries are part of rcssserver3d they should be added! I don't really understand what you mean I think. I haven't done any runtime tests. Jeff, can I do the review and you sponsor him or do you need to do the review then as well (I can't sponsor). Tim -- Tim Niemueller <tim@xxxxxxxxxxxxx> www.niemueller.de ================================================================= Imagination is more important than knowledge. (Albert Einstein) _______________________________________________ Fedora-robotics-list mailing list Fedora-robotics-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/fedora-robotics-list
