Product: Fedora Version: rawhide Component: Package Review Remi Collet <fedora@xxxxxxxxxxxxxxxxx> has asked for fedora_requires_release_note: Bug 1336735: Review Request: php-Slim3 - PHP micro framework https://bugzilla.redhat.com/show_bug.cgi?id=1336735 --- Comment #4 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- [!]: Package is named according to the Package Naming Guidelines. "As for other packages, name should only use lowercase, underscore and slash replaced by dash. " So php-slim3 should be prefered [!]: If the package is a rename of another package, proper Obsoletes and Provides are present. Obsoletes: %{name}-tests < 3 Uneeded, this package doesn't exists [~] EL-5 stuff unneeded (not a blocker) [x]: %check is present and all tests pass. PHP 5: OK PHP 7: OK I encouter failure on local build, but ok in mock (so not a blocker) 1) Slim\Tests\ContainerTest::testGetWithDiConfigErrorThrownAsInvalidArgumentExcept ion Failed asserting that exception of type "InvalidArgumentException" matches expected exception "\Interop\Container\Exception\ContainerException". Message was: "Identifier "doesnt-exist" is not defined." at /dev/shm/extras/BUILD/Slim-794073a27b2dd9ef492124263038291b7f8daeb3/tests/Conta inerTest.php:74 /dev/shm/extras/BUILDROOT/php-Slim3-3.4.1-1.fc21.remi.x86_64/usr/share/php/Slim 3/Container.php:125 /dev/shm/extras/BUILD/Slim-794073a27b2dd9ef492124263038291b7f8daeb3/tests/Conta inerTest.php:77 Minors - also fix package name in spec header - as you keep changelog from php-Slim, add a changelog entry "renamed to ..." -- relnotes-content mailing list relnotes-content@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/relnotes-content@xxxxxxxxxxxxxxxxxxxxxxx
