[Bug 482947] Mark localized files with %lang, fix minor packaging issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=482947

--- Comment #16 from John J. McDonough <wb8rcr@xxxxxxxx> 2010-05-25 19:17:25 EDT ---
Sorry, Comment 11 wasn't very helpful.  However, what I was most concerned
about was the section in your earlier patch:

%find_lang %{name} --with-gnome --all-name
for F in $RPM_BUILD_ROOT%{_defaultdocdir}/HTML/index-*.html ; do
  L=`echo ${F} | %{__sed} 's/.*\/index-\(.*\)\.html$/\1/'`
  echo "%%lang(${L}) ${F#$RPM_BUILD_ROOT}" >> html.lang
done

which just didn't make any sense to me.  I see it is gone from your most recent
patches.  This is the particular snippet I didn't understand and which caused
rpmbuild to fail Reviewing it now it appears that perhaps some other document
was organized as index-fr.html, index-en.html, etc.  The release notes aren't
like that so I was struggling trying to figure out the point of that code.

I believe the current specfile contains most of your patches, I'll review it to
be sure we got them all.  The release notes spec file is actually produced
programatically, and the actual spec file might change depending on the
writer's needs, but once I get all your suggestions into the script, then all
documents will benefit.

Sorry if I'm a little slow on the uptake here.  I'm not trying to be contrary,
just trying to understand.  And I do appreciate your help.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
--
relnotes-content mailing list
relnotes-content@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/relnotes-content


[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Gnome Users]     [KDE Users]

  Powered by Linux