On Tue, 2009-09-01 at 22:46 -0400, Jack Tanner wrote: > Tom Moertel wrote: > > I packaged plyr tonight: > > > > http://community.moertel.com/rpms/fedora/10/SPECS/R-plyr.spec > > Thanks for taking a stab at plyr. I'm a very inexperienced packager, but > these are the questions that I'd be asking if I were a reviewer. > > - Do you need to worry about the requires (R-RUnit R-abind R-tcltk)? Two out of three are already done and in the repo R-tcltk will have to be done. > - It seems wrong to hard-code Source0 rather than making it conditional > on the variables defined in the spec. See my RMySQL spec (which could be > totally goofy, and I've had no feedback on it) here: > https://www.redhat.com/archives/fedora-r-devel-list/2009-August/msg00007.html The Source0 is not wrong, changing it to use the macro make just the maintenance of the package easier (you won't have to change the Source0) > - Since plyr is noarch, you could remove the commented-out arch-specific > stuff. +1 to clean the spec You have also the: - change the BR tetex-latex to tex(latex) Regards, Pierre _______________________________________________ Fedora-r-devel-list mailing list Fedora-r-devel-list@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-r-devel-list
