Hi,
Le 13/10/2021 à 22:17, Otto Urpelainen a écrit :
Hello php sig,
For some time already, I have had in mind to extend the php Packaging
Guidelines with some suggestions about test suites. I am not a php
expert, so this work is based on simply trying to codify the already
established practices. Before submitting a pull request for the
Guidelines, I would appreciate if you could spare some of your time to
"pre-review" my work and give feedback [1].
I am mostly concerned about the autoloader testing section. It talks
about the "generated autoloader", for the first time in the guidelines.
Autoloader generation is explained in the wiki page PHP/PackagingTips
[2]. The page argues against adding that information to the Guidelines,
because the autoloader is not mandatory. However, the word "should"
already carries the right meaning in the guidelines. Would it make sense
to move that section to the Guidelines, appropriately marked with
"should"? Some people (like me) only check the Guidelines and do not
always find additional information hiding in the wiki.
Thanks for working on improving Guidelines
I think running test suite is already in the Packaging Guidelines
as a "should"
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_test_suites
I'm used to consider other things as "tips", which are not
really needed in the Guidelines, and easier to maintain in the SIG page
What seems really missing is a link in the Guidelines to the SIG page.
Notice, testing the generated autoloader make sense when there is no
test suite (as test suite should uses it, and thus tests it).
Remi
[1]:
https://pagure.io/fork/oturpe/packaging-committee/diff/master..php-test-guidance
[2]: https://fedoraproject.org/wiki/SIGs/PHP/PackagingTips
Regards,
Otto
_______________________________________________
php-devel mailing list -- php-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to php-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/php-devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
_______________________________________________
php-devel mailing list -- php-devel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to php-devel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/php-devel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
