Re: Missing PAGE_MASK macro on PPC arches

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> fbtv (Frame Buffer TV) from xawtv package.
> > It's likely not a bug.  PowerPC can have 4KiB or 64KiB pages, and
> > PAGE_MASK is dependent upon the kernel config option being set one way
> > or another since it's derived from PAGE_SHIFT.
> >   
> 
> Yep, we just should use getpagesize() for now.


I agree. But what about binutils than ?

../../bfd/trad-core.c:117: error: 'PAGE_SIZE' undeclared (first use in this function)
^^^
this seems that binutils rely on all arches on page.h exported PAGE_SIZE ?

I have same problem on alpha, only one arch (till now) wich page.h doesnt export 
PAGE_SIZE, so i used to move PAGE_SIZE out of kernel pragma space like:


cat ../SOURCES/linux-2.6.21-alpha_pagesize.patch
--- linux/include/asm-alpha/page.h.orig 2007-06-25 00:19:41.000000000 +0200
+++ linux/include/asm-alpha/page.h      2007-06-25 00:21:46.000000000 +0200
@@ -1,15 +1,15 @@
 #ifndef _ALPHA_PAGE_H
 #define _ALPHA_PAGE_H

-#ifdef __KERNEL__
-
-#include <asm/pal.h>
-
 /* PAGE_SHIFT determines the page size */
 #define PAGE_SHIFT     13
 #define PAGE_SIZE      (1UL << PAGE_SHIFT)
 #define PAGE_MASK      (~(PAGE_SIZE-1))

+#ifdef __KERNEL__
+
+#include <asm/pal.h>
+
 #ifndef __ASSEMBLY__

 #define STRICT_MM_TYPECHECKS


 /chris

Attachment: pgpUi3esAHdG1.pgp
Description: PGP signature

--
Fedora-maintainers mailing list
Fedora-maintainers@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers
--
Fedora-maintainers-readonly mailing list
Fedora-maintainers-readonly@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/fedora-maintainers-readonly

[Index of Archives]     [Fedora Users]     [Fedora Development]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux