On Tue, 2006-07-11 at 21:24 -0400, Jeremy Katz wrote: > On Tue, 2006-07-11 at 18:56 -0500, Tom 'spot' Callaway wrote: > > > > Uses incorrect dist tag > > > > ======================== > > > > anacron-2.3-38.FC6.src.rpm > > > > The "all caps" hardcoded dist tag is wrong. Instead, you should use > > %{?dist} to let the buildsystem (both plague and brew support this) > > determine what the distribution tag is. It will fill in %{dist} > > with .fc6, for example. The dist tag bits are documented here: > > http://fedoraproject.org/wiki/DistTag > > > > Hardcoding the value for the dist tag is no longer allowed, since the > > buildsystem can do it for you. > > I thought that things allowed hardcoding as long as you used the "right" > value. Granted, doing so is probably kind of silly, but forcing > syntactic sugar is also overkill Ehh. The standard says no, because: - Its easy to get it wrong. - It leads to things like .fc5 packages in the devel branch - It opens the door to arguments like "if i can hardcode .fc6, why can't I hardcode .omg.wtf.bbq also" ? ~spot -- Tom "spot" Callaway: Red Hat Technical Team Lead || GPG ID: 93054260 Fedora Extras Steering Committee Member (RPM Standards and Practices) Aurora Linux Project Leader: http://auroralinux.org Lemurs, llamas, and sparcs, oh my!