Re: [OS-BUILD PATCHv4 0/5] Minor updates for common config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Patrick Talbert on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3423#note_2175150675

@pbrobinson

Sorry for the trouble with this. I will merge it as-is.

Just to explain what is going on, the check done here is that the commit
summary has a `Signed-off-by` string which matches the commit author's name &
email. The two older commits have your @redhat.com address in the Author
details and now that the summary signoff is using the @gmail address, it
reports the mismatch.

```
$ git show --format=fuller origin/merge-requests/3423 | head -n 5
commit ddf33cbaa700ac8312e106149bc11acaa97f0752
Author:     Peter Robinson <pbrobinson@xxxxxxxxxx>
AuthorDate: Mon Sep 30 10:03:33 2024 +0100
Commit:     Peter Robinson <pbrobinson@xxxxxxxxx>
CommitDate: Tue Oct 22 19:10:32 2024 +0100
```

For the check of the MR description `Signed-off-by` line, we *assume* the MR
author details match those of the head commit. That's because the user details
gitlab provides about the MR author do not always include an email address as
people can choose for that to be private.


Anyway, there are always edge-cases like these and we're still discussing how
to try to handle them. Sorry again for the noise.

-- 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux