On Fri, Oct 18, 2024 at 8:57 AM Ian Pilcher <arequipeno@xxxxxxxxx> wrote: > > On 10/17/24 1:36 PM, Ian Pilcher wrote: > > Ran 'dnf update' on my NAS, and discovered that the leds_pca9532 module > > has been removed. (CONFIG_LEDS_PCA9532 was changed from 'm' to not > > set.) > > > > Is there some reason for this removal? > > Justin - > > This was changed in this commit[1] without any real explanation. (Oddly > that same commit *enables* the driver in several non-x86_64 kernel > configs.) > > What was the reason for this? Those commits are useless from an informational standpoint and give no real information at all. We have to build out of dist-git, but the kernel is not maintained in dist-git, a script prepared dist-git based on what is in the source tree. That is why the commit you point to there is all over the place. https://gitlab.com/cki-project/kernel-ark is the source of truth for the Fedora kernel. In this case an MR came in and this seems to be unintentional fallout from it. Reviews on leds, dacs, thermal, regulators, etc are fairly hard because we really do not know what hardware is in the wild. I have reverted the offending commit in the fedora-6.11 branch, and put in a revert MR for os-build. In the meantime, I tagged the revert as include in release, so rawhide should be built correctly again starting tomorrow. Justin > [1] > https://src.fedoraproject.org/rpms/kernel/c/943f7ca039856de1015114a84ac35031b635d390 > > -- > ======================================================================== > If your user interface is intuitive in retrospect ... it isn't intuitive > ======================================================================== > -- _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
