Re: [OS-BUILD PATCH] redhat: Drop bpftool from kernel spec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Viktor Malik on gitlab.com
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3338#note_2092647212

@dzickusrh thanks for the comment!

> I am curious how you handle updating bpftool package? One scenario that has
been tricky in the past is a newer bpftool update using an older buildroot
kernel-devel. I believe you get a vmlinux.h that is mismatched.

IIUC, bpftool should be backwards-compatible with the kernel, i.e. it should
be no problem if bpftool is built against `vmlinux.h` from an older kernel
version than bpftool comes from. So, my plan is to basically build bpftool
against the current buildroot, same as any other package.

> And does the bpftool accidentally use the build system files to make checks
instead of the buildroot? We had to put Makefile hacks for bpftool to inject
the right vmlinux.h file and others?? into the build process to override the
system files found on the AWS builders.

If I understand this one correctly, it's a good point. Looking at bpftool's
`Makefile`, it builds its own `vmlinux.h` from BTF and by default, it takes
BTF from KBuild (which we won't have) or from the running system (which we
don't want). So, I'll need to update the new bpftool specfile to pass the
correct `vmlinux.h` coming from `kernel-devel`. It should be as simple as
passing the path via `VMLINUX_H` build variable, though.

If you have any specific cases where you think this is not sufficient, I'll be
happy to look into them.

-- 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux