[OS-BUILD PATCHv2] redhat: rh_flags: declare proper static methods when CONFIG_RHEL_DIFFERENCES is not set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Rafael Aquini <aquini@xxxxxxxxxx>

redhat: rh_flags: declare proper static methods when CONFIG_RHEL_DIFFERENCES is not set

rh_print_flags() and rh_add_flag() are defined as prototypes when
CONFIG_RHEL_DIFFERENCES is not set leading to the following CLANG woe:

 ./include/linux/rh_flags.h:32:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    32 | void rh_add_flag(const char *flag_name) { };
       | ^
       | static
 2 warnings generated.

breaking CKI_Rawhide_ClangLTO pipelines

Signed-off-by: Rafael Aquini <aquini@xxxxxxxxxx>

diff --git a/include/linux/rh_flags.h b/include/linux/rh_flags.h
index blahblah..blahblah 100644
--- a/include/linux/rh_flags.h
+++ b/include/linux/rh_flags.h
@@ -28,7 +28,7 @@ void rh_print_flags(void);
 	unlikely(__ret_mark_once);					\
 })
 #else
-void rh_print_flags(void) { };
-void rh_add_flag(const char *flag_name) { };
+static void rh_print_flags(void) { }
+static void rh_add_flag(const char *flag_name) { }
 #endif
 #endif

--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/3256

-- 
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora General Discussion]     [Older Fedora Users Archive]     [Fedora Advisory Board]     [Fedora Security]     [Fedora Devel Java]     [Fedora Legacy]     [Fedora Desktop]     [ATA RAID]     [Fedora Marketing]     [Fedora Mentors]     [Fedora Package Announce]     [Fedora Package Review]     [Fedora Music]     [Fedora Packaging]     [Centos]     [Fedora SELinux]     [Coolkey]     [Yum Users]     [Tux]     [Yosemite News]     [KDE Users]     [Fedora Art]     [Fedora Docs]     [USB]     [Asterisk PBX]

  Powered by Linux