From: Prarit Bhargava <prarit@xxxxxxxxxx>
redhat/self-test: Remove rpmlint test
rpmlint reports errors and warnings on syntax and variable usage in spec
files. Hundreds of errors are reported when rpmlint is run on the
kernel.spec. These errors are for everything from RPM_BUILD_ROOT usage to
listing unversioned package dependencies. These errors are all caused by
explicit design choices by the kernel maintainers and spec authors.
For example, the use of RPM_BUILD_ROOT is required to move kernel compile
artificats from one directory to another in the rpm build phase which
seems to be an exception called out in rpmlint (but is still reported as
an error).
These errors can be blocked but only at a global level; that is, if error
reporting for these issues were blocked then new issues would not be
reported.
The rpmlint test failures don't offer new insight into the kernel spec.
For now, remove the rpmlint test from the self-tests.
Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
diff --git a/redhat/self-test/1001-rpmlint.bats b/redhat/self-test/1001-rpmlint.bats
deleted file mode 100644
index blahblah..blahblah 0
--- a/redhat/self-test/1001-rpmlint.bats
+++ /dev/null
@@ -1,21 +0,0 @@
-#!/usr/bin/env bats
-# Purpose: This test runs rpmlint on the source rpm.
-
-load test-lib.bash
-
-@test "rpmlint" {
- if ! test -x /usr/bin/rpmlint; then
- skip "The rpmlint package is not installed"
- else
- skip "Skip rpmlint test pending kernel.spec.template changes"
- fi
-
- numsrpms=$(find "$BATS_TEST_DIRNAME"/.. -name "*.rpm" | wc -l)
- if [ "$numsrpms" != "1" ]; then
- skip "Only one SRPM should be in $BATS_TEST_DIRNAME/redhat/rpms/SRPMS."
- fi
-
- srpm=$(find "$BATS_TEST_DIRNAME"/.. -name "*.rpm")
- run rpmlint $srpm
- check_result
-}
--
https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2649
_______________________________________________
kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
