From: Herton R. Krzesinski on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/2339#note_1297506964 About changing the DISTRO, may be it's be useful, although we default for RHEL as usually a RHEL developer wants to test the build on brew (rhel) instead of centos even if we are building/integrating it first on centos. So that's why I think no one complained so far, the maintainer (eg. me) is usually the one which uses the DISTRO value (only at the dist-git sync step), but that has been working on the centos side so far passing through the command line, so I didn't noticed it was broken too since I don't use Makefile.variables. To determine the where the value comes, we could use origin like ```ifeq ("$(origin BUILD_TARGET)", "command line")```, but I didn't think what the logic should be. I think we should keep DIST as is on Makefile.variables and logic is done in Makefile? I think could be possible? I'm not sure if there is a problem. Right now we change the DIST in Makefile.variables when kernel-ark is forked to RHEL, for example, centos9 kernel src.git sets it to DIST ?= .el9 in Makefile.variables. _______________________________________________ kernel mailing list -- kernel@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to kernel-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/kernel@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
